Fixing circular symlinks (issue 513) #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
przadka
force-pushed
the
circular-links
branch
8 times, most recently
from
67e4246
to
acdc5e9
Compare
|
@ppolewicz After some additional time debugging symlinks on Windows this PR is ready for review. Some tests are skipped on Windows with PyPy, because PyPy do not support symlinks on Windows. I did a self-review before writing this comment. There are still some minor FIXMEs and I would appreciate some feedback on them. |
ppolewicz
reviewed
May 1, 2023
Capped symlinks visits while scanning New tests added Added pytest-timeout to test requirements Changelog updated
Circular loops are not detected as soon as we visit the same path twice Improved docstring for _walk_relative_paths
No longer secretly skipping symlinks pointing to parent of scan directory Added warning msg when circular symlinks found Set of visited symlinks now stores inode integers rather than full paths
przadka
commented
May 5, 2023
ppolewicz
reviewed
May 8, 2023
Co-authored-by: Paweł Polewicz <p.polewicz@gmail.com>
ppolewicz
reviewed
May 11, 2023
ppolewicz
reviewed
May 13, 2023
…ist comprehension to reduce memory usage Co-authored-by: Paweł Polewicz <p.polewicz@gmail.com>
Co-authored-by: Paweł Polewicz <p.polewicz@gmail.com>
Co-authored-by: Paweł Polewicz <p.polewicz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Capped symlinks visits while scanning
New tests added
Added pytest-timeout to test requirements